[16.0][MIG] fleet vehicle purchase : Migration to 16.0 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (9 of 9 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_purchase Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_purchase/es/
Currently translated at 100.0% (9 of 9 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_purchase Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_purchase/it/
Currently translated at 100.0% (9 of 9 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_purchase Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_purchase/pt_BR/
acsonefho
suggested changes
Oct 16, 2024
| @api.depends("fleet_vehicle_from_po") | ||
| def _compute_fleet_vehicle_id(self): | ||
| for rec in self: | ||
| if rec.fleet_vehicle_from_po: |
There was a problem hiding this comment.
I don't understand this boolean field. It sets to True when the order is related to a fleet vehicle. So this if section will always be True in this case.
So when the order is not related to a fleet vehicle, it'll fill the fleet_vehicle_id is an empty recordset (and that's also the expected behavior).
There was a problem hiding this comment.
This is to cover a practical case where we want to order pieces for several fleet vehicle in one PO:
- If we put the vehicle on the PO, it will be propagate on all purchase order lines and the vehicle will be readonly in the view. In this case the PO is for one vehicle.
- If we don't put the vehicle on the PO, we can order pieces for different vehicles in one PO, changing the vehicle on each line. This allows a big customer to order pieces for more than one vehicle in one PO.
lmarion-source
force-pushed
the
16.0-mig-fleet_vehicle_purchase
branch
2 times, most recently
from
ad097ce
to
ed9dae2
Compare
Initially, there was only one vehicle for one PO. Now, if the vehicle is set on the PO, all the PO lines are related to this vehicle But if the vehicle is not set on the PO, the user can decide to have different vehicles on every line. Use case is a grouped purchase of several items for several vehicles.
lmarion-source
force-pushed
the
16.0-mig-fleet_vehicle_purchase
branch
from
ed9dae2
to
bb02ffd
Compare
acsonefho
approved these changes
Oct 16, 2024
|
/ocabot migration fleet_vehicle_purchase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.